Remove obsolete DataNode audit log appender#18292
Open
CRZbulabula wants to merge 1 commit into
Open
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #18292 +/- ##
============================================
+ Coverage 42.83% 42.99% +0.16%
Complexity 374 374
============================================
Files 5362 5362
Lines 381409 381405 -4
Branches 49509 49511 +2
============================================
+ Hits 163368 163992 +624
+ Misses 218041 217413 -628 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Description
The DataNode Logback configuration still declares an
AUDITrolling file appender that targetslog_datanode_audit.log, together with theIoTDB_AUDIT_LOGGERlogger. The audit implementation has already been removed, so there are no remaining Java callers. However, Logback initializes the rolling file appender when the DataNode starts, which creates an unused audit log file.This PR:
AUDIT_LOGGER_NAMEconstant.This change only removes the obsolete standalone audit log file output. It does not change the existing audit privilege or authorization behavior.
Verification
mvn spotless:apply -pl iotdb-core/node-commonsmvn compile -pl iotdb-core/node-commons -DskipTestsxmllintThis PR has:
Key changed files
iotdb-core/datanode/src/assembly/resources/conf/logback-datanode.xmliotdb-core/datanode/src/test/resources/datanode{1,2,3}conf/logback.xmliotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/conf/IoTDBConstant.java