[Consensus] Fix concurrent access to IoTConsensus configuration#18290
Open
jt2594838 wants to merge 1 commit into
Open
[Consensus] Fix concurrent access to IoTConsensus configuration#18290jt2594838 wants to merge 1 commit into
jt2594838 wants to merge 1 commit into
Conversation
hongzhi-gao
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Concurrent configuration storage
TreeSetused byIoTConsensusServerImplwith a concurrent set backed byConcurrentHashMap.newKeySet().Collection<Peer>and copy it into the internal concurrent set so callers cannot supply a non-thread-safe implementation.Deterministic configuration snapshots
getConfiguration()to preserve the deterministic iteration order previously provided byTreeSet.Concurrency coverage
Verification
mvn test -pl iotdb-core/consensus -Dtest=IoTConsensusServerImplTest,ReplicateTest,StabilityTestThis PR has:
Key changed/added classes
IoTConsensusServerImplIoTConsensusIoTConsensusServerImplTest