Skip to content

fix: track batch position delete references#842

Open
u70b3 wants to merge 1 commit into
apache:mainfrom
u70b3:fix-position-delete-batch-metadata
Open

fix: track batch position delete references#842
u70b3 wants to merge 1 commit into
apache:mainfrom
u70b3:fix-position-delete-batch-metadata

Conversation

@u70b3

@u70b3 u70b3 commented Jul 24, 2026

Copy link
Copy Markdown

Summary

  • collect referenced data-file paths when writing position deletes as an Arrow batch
  • update referenced-path metadata only after the underlying write succeeds
  • reject null batch inputs and null file paths
  • cover single-file, multi-file, mixed, empty, and invalid batches

Testing

  • pre-commit run --files src/iceberg/data/position_delete_writer.cc src/iceberg/test/data_writer_test.cc
  • build-gcc14/src/iceberg/test/data_test (157 tests passed)
  • git diff --check

This contribution was developed with assistance from OpenAI Codex. The implementation and tests were reviewed and verified by the author.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant