Avoid generating ref.as_non_null for table initializers in fuzzer#8928
Open
stevenfontanella wants to merge 1 commit into
Open
Avoid generating ref.as_non_null for table initializers in fuzzer#8928stevenfontanella wants to merge 1 commit into
stevenfontanella wants to merge 1 commit into
Conversation
tlively
reviewed
Jul 22, 2026
tlively
left a comment
tlively
left a comment
Member
There was a problem hiding this comment.
I guess setupGlobals() must already do something similar, but what happens to instructions that reference the table whose type is changed? How are they updated to account for the new type?
Can we add a new .wast file to the test suite that the fuzzer will pick up as initial contents that will trigger this new code path?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8911.
ref.as_non_nullis not a constant expression, so it's not allowed in table initializers. Repro output with this PR.See the equivalent code in setupGlobals.