Test harness and flag tls connections#86
Open
MrIron-no wants to merge 3 commits into
Open
Conversation
…rld. Provides a reusable FakeHub, compose stack, and fixtures so S2S behaviour (including message-tags) can be asserted without a live ircu network. Co-authored-by: Cursor <cursoragent@cursor.com>
Use it in ccontrol CHECK so an optional account field before :realname no longer shifts the fullname index; cover with unit and harness tests. Co-authored-by: Cursor <cursoragent@cursor.com>
Parse FLAG_TLS from SERVER flags, expose it in mod.debug SERVERINFO, and set the uplink iServer TLS bit whenever the outbound connection is TLS. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test/harness) with a fake P10 hub and Dockerized gnuworld/Postgres, plus link and message-tags coverage.StringTokenizer::trailing()and use it in ccontrol CHECK so an optional account field before:realnameno longer breaks fullname parsing; cover with unit and harness tests.+z/FLAG_TLS), show it in mod.debugSERVERINFO, and mark the uplink as TLS whenever the outbound link is TLS (even if the hub SERVER line omits+z).Test plan
cd test/harness && pytest -v(host build installed intobin//lib/first; Docker available)test_msgtags,test_link,test_ccontrol_check, andtest_debug_serverinfopassmake test_stringtokenizer_trailing && ./test_stringtokenizer_trailingtls = yes,SERVERINFOon the uplink showstls=yes; plain link showstls=no; leaf with+zshowstls=yes