fix: Grid suggestion menu item padding (BLO-1225)#2910
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (9)
📒 Files selected for processing (3)
📝 WalkthroughWalkthroughGrid suggestion menu item typography and spacing are adjusted consistently across Ariakit, Mantine, and ShadCN implementations. ChangesGrid suggestion item styling
Estimated code review effort: 1 (Trivial) | ~3 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
@blocknote/ariakit
@blocknote/code-block
@blocknote/core
@blocknote/mantine
@blocknote/react
@blocknote/server-util
@blocknote/shadcn
@blocknote/xl-ai
@blocknote/xl-docx-exporter
@blocknote/xl-email-exporter
@blocknote/xl-multi-column
@blocknote/xl-odt-exporter
@blocknote/xl-pdf-exporter
commit: |
|
Summary
This PR adjusts the padding around the grid suggestion menu/emoji picker. This is because on some platforms, certain emojis are very large and have a black border. When an item/emoji is selected, a contrasting background color is applied which isn't clearly visible with these emojis. Therefore, the items have been made smaller but padding has been increased to make their overall size the same as before.
Closes #2819
Rationale
See above.
Changes
See above.
Impact
N/A
Testing
Updated e2e screenshots.
Screenshots/Video
N/A
Checklist
Additional Notes
N/A
Summary by CodeRabbit