pgtle_versions.md: fix wrong uninstall_extension() version claim#59
Merged
jnasbyupgrade merged 4 commits intoJul 26, 2026
Merged
Conversation
…ostgres-Extensions#54) pgtle_versions.md claimed `pgtle.uninstall_extension()` was added in pg_tle 1.4.0. Checking the tagged pg_tle source directly shows it has existed unchanged since v1.0.0 (both the one-arg and two-arg overloads). The only relevant 1.4.0 change was `create_base_type()` gaining alignment/storage parameters; the real install/uninstall API break is at 1.5.0, where `install_extension()` gains a required `schema` parameter. Changes only in pgxntool. No related changes in pgxntool-test. Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…ions Per PR59 review: uninstall_extension() never changes across these version ranges, so it doesn't belong in a doc about version boundaries. Also drop the historical correction narrative (what was previously documented, how it was confirmed) - the file should describe current API state only.
Stating 'install_extension() still has no schema parameter' in ranges where it doesn't change is the same problem as the uninstall_extension() mentions just removed - this doc documents API changes, not unchanged state. Only note an API bullet where something actually changed at that boundary.
- Drop '(see Features above)' cross-reference - no other entry does this and it's 11 lines from the section it points to - Make '1.5.0' header bare and list 'Changed install_extension() signature' as its own bullet, matching the list-item structure of the other two facts under it
jnasbyupgrade
merged commit Jul 26, 2026
aab8f2b
into
Postgres-Extensions:master
3 of 4 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #54.
pgtle_versions.mdclaimedpgtle.uninstall_extension()was added in pg_tle 1.4.0. Checking the tagged pg_tle source directly (pg_tle--1.0.0.sql,pg_tle--1.0.1--1.0.4.sql,pg_tle--1.3.4--1.4.0.sql,pg_tle--1.4.0--1.5.0.sql) shows:uninstall_extension(extname text)and the(extname text, version text)overload have both existed unchanged since v1.0.0create_base_type()(added alignment/storage params) — no install/uninstall changeinstall_extension()gains a requiredschemaparameterCorrected the
1.0.0-1.4.0/1.4.0-1.5.0range descriptions and the "Key API Changes by Version" section to reflect this. Doesn't change any generated SQL or code — the version-range split pgxntool uses is still correct, only the doc's stated rationale was wrong.Doc-only change, no code changes.