ci: add PG18 to test matrix; skip test job for doc-only PRs#37
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/ci.yml:
- Around line 45-54: Update the `gh api` jq selection in the doc-only check to
emit both each file’s current `filename` and its `previous_filename` when
present, then run both through the existing `doc_only` allowlist loop. Preserve
the current behavior for non-renamed files and ensure any non-documentation
rename path sets `doc_only=false`.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: e1d68a53-2a80-43e8-a9d0-d297300d97cb
📒 Files selected for processing (3)
.github/workflows/CLAUDE.md.github/workflows/ci.yml.github/workflows/run-tests.yml
A rename like src/foo.sql -> docs/foo.md only exposed the new filename to the doc-only check, so it would incorrectly bypass tests despite changing a non-documentation path. Check previous_filename too. Found by CodeRabbit on the paired pgxntool-test PR: Postgres-Extensions/pgxntool-test#37 (comment) Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
A rename like src/foo.sql -> docs/foo.md only exposed the new filename to the doc-only check, so it would incorrectly bypass tests despite changing a non-documentation path. Check previous_filename too. Found by CodeRabbit: Postgres-Extensions#37 (comment) Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
A rename like src/foo.sql -> docs/foo.md only exposed the new filename to the doc-only check, so it would incorrectly bypass tests despite changing a non-documentation path. Check previous_filename too. Found by CodeRabbit on the paired pgxntool-test PR: Postgres-Extensions/pgxntool-test#37 (comment) Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
- run-tests.yml: add PostgreSQL 18 to the test matrix. - ci.yml: resolve job gains a doc-only check (every changed file is *.md/*.asc/*.adoc/*.asciidoc, anywhere including .claude/, never under .github/) that gates the test job directly. claude-review is unaffected (separate workflow, own gate). Paired with the equivalent pgxntool-side bypass: Postgres-Extensions/pgxntool#71 Fixes Postgres-Extensions/pgxntool#62 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
A rename like src/foo.sql -> docs/foo.md only exposed the new filename to the doc-only check, so it would incorrectly bypass tests despite changing a non-documentation path. Check previous_filename too. Found by CodeRabbit: Postgres-Extensions#37 (comment) Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
249ced7 to
1c17058
Compare
|
Note on the CodeRabbit rename-file finding (originally on commit fadfa49, in this outdated thread): that thread shows as outdated because the branch was later rebased onto current master (fixing an unrelated stale-fork-branch test failure) and force-pushed, so its anchor commit no longer exists in the history. The fix itself is still present — current |
Related pgxntool-test PR: Postgres-Extensions/pgxntool-test#37 --------- Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
1 participant
Related pgxntool PR: Postgres-Extensions/pgxntool#71
Adds PostgreSQL 18 to
run-tests.yml's test matrix.Also adds a doc-only bypass to
ci.yml'sresolvejob: when every changed file in a PR is pure documentation (*.md,*.asc,*.adoc,*.asciidoc, anywhere including.claude/, but never under.github/— workflow definitions carry real behavioral weight regardless of extension), thetestjob is skipped entirely. Surfaced by PR #36 (a pure.claude/commands/pr.mddoc change) running the full Postgres test matrix unnecessarily.claude-reviewis unaffected (separate workflow, own gate) and still runs.Fixes Postgres-Extensions/pgxntool#62.