fix(android): sync mobile style group nav with desktop sidebar (#862)#864
Open
HKLHaoBin wants to merge 1 commit into
Open
fix(android): sync mobile style group nav with desktop sidebar (#862)#864HKLHaoBin wants to merge 1 commit into
HKLHaoBin wants to merge 1 commit into
Conversation
Expose polish mode and marketplace via a bottom-sheet under the Style tab, matching desktop NAV_TREE grouping for issue Open-Less#862. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
Summary
subItemLabelKeytonavLabels.tsfor shared desktop/mobile labelsCloses #862
Test plan
Made with Cursor
PR Type
Bug fix, Enhancement
Description
Add MobileStyleSheet bottom sheet for style group navigation
Extract subItemLabelKey into shared navLabels module
Update bottom nav to open style sheet instead of direct style tab
Remove style tab from fixed bottom tabs list
Diagram Walkthrough
File Walkthrough
FloatingShell.tsx
Integrate MobileStyleSheet and restyle bottom navopenless-all/app/src/components/FloatingShell.tsx
MobileStyleSheet.tsx
Add MobileStyleSheet component for style groupopenless-all/app/src/components/MobileStyleSheet.tsx
navLabels.ts
Extract subItemLabelKey to shared navLabels moduleopenless-all/app/src/lib/navLabels.ts