fix(android): hide overview activity heatmap on mobile (#861)#863
Open
HKLHaoBin wants to merge 1 commit into
Open
fix(android): hide overview activity heatmap on mobile (#861)#863HKLHaoBin wants to merge 1 commit into
HKLHaoBin wants to merge 1 commit into
Conversation
Skip getActivityStats IPC and ActivityHeatmapCard when useMobileLayout() is true so narrow screens avoid horizontal overflow and unnecessary work. Closes Open-Less#861 Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
Summary
getActivityStats()IPC whenuseMobileLayout()is true so Android / narrow screens do not fetch 365-day activity data.ActivityHeatmapCardon mobile layout, avoiding fixed-width heatmap overflow that broke bottom-nav alignment.Closes #861
Test plan
getActivityStatscallmobile)Made with Cursor
PR Type
Bug fix, Enhancement
Description
Skip activity data request when useMobileLayout is true
Hide ActivityHeatmapCard on narrow screens to avoid overflow
Fix bottom-nav alignment and improve mobile performance
Diagram Walkthrough
flowchart LR A[Overview.tsx] --> B{mobile layout?} B -- Yes --> C[Skip getActivityStats & render] B -- No --> D[Fetch activity & show heatmap]File Walkthrough
Overview.tsx
Conditionally skip heatmap on mobileopenless-all/app/src/pages/Overview.tsx
IPC