Skip to content

fix(vm): reduce registry rootfs staging pressure#2425

Merged
drew merged 1 commit into
mainfrom
fix/2423-rust-vm-rootfs-disk/pimlock
Jul 22, 2026
Merged

fix(vm): reduce registry rootfs staging pressure#2425
drew merged 1 commit into
mainfrom
fix/2423-rust-vm-rootfs-disk/pimlock

Conversation

@pimlock

@pimlock pimlock commented Jul 22, 2026

Copy link
Copy Markdown
Collaborator

Summary

Reduce peak disk usage while building registry-backed VM root filesystems, and keep the formatter error that explains failures instead of masking it with a missing fallback path. The rust-vm job now validates that the GitHub-hosted runner already provides the required ext4 tools without installing packages.

Related Issue

Closes #2423

Changes

  • Remove compressed and extracted registry-layer staging data after all layers are merged and before the ext4 image is formatted.
  • Preserve executed mke2fs/mkfs.ext4 failures over unavailable fallback candidates, with regression coverage for failure, missing-tool, and successful-fallback behavior.
  • Validate mke2fs, mkfs.ext4, and debugfs on the rust-vm runner without installing e2fsprogs in the job.
  • Deviations from the approved plan: none.

Testing

  • mise run pre-commit passes
  • Unit tests added/updated
  • E2E tests added/updated (not applicable; no files under e2e/ changed)
  • mise exec -- cargo test -p openshell-driver-vm

Checklist

  • Follows Conventional Commits
  • Commits are signed off (DCO)
  • Architecture docs updated (not applicable; no architecture or user-facing behavior changed)

Remove temporary registry layer data before formatting the merged rootfs, preserve formatter execution failures over missing fallbacks, and validate required ext4 tools in rust-vm CI.

Closes #2423

Signed-off-by: Piotr Mlocek <pmlocek@nvidia.com>
@pimlock pimlock added the test:e2e Requires end-to-end coverage label Jul 22, 2026
@github-actions

Copy link
Copy Markdown

Label test:e2e applied for 3aea4c9. Open the existing run and click Re-run all jobs to execute with the label set. The run will execute the standard E2E suite after building the required gateway and supervisor images once. The matching required CI gate status on this PR will flip green automatically once the run finishes.

@drew
drew added this pull request to the merge queue Jul 22, 2026
Merged via the queue into main with commit ca31805 Jul 22, 2026
66 checks passed
@drew
drew deleted the fix/2423-rust-vm-rootfs-disk/pimlock branch July 22, 2026 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test:e2e Requires end-to-end coverage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: rust-vm E2E intermittently fails with masked ext4 formatter error

2 participants