Skip to content

fix(policy): keep internal allowed IP proposals pending#2416

Open
alangou wants to merge 1 commit into
mainfrom
alangou/os-188-tava-2026-05-fsr-04-flag-private-allowed_ips-in-draft
Open

fix(policy): keep internal allowed IP proposals pending#2416
alangou wants to merge 1 commit into
mainfrom
alangou/os-188-tava-2026-05-fsr-04-flag-private-allowed_ips-in-draft

Conversation

@alangou

@alangou alangou commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Summary

Keep draft policy proposals pending when allowed_ips targets private or internal ranges. Re-evaluate auto-approval against the rule currently stored after edits and mechanistic deduplication so stale proposal analysis cannot bypass human review.

Related Issue

closes OS-188

Changes

  • Classify IPv4 and IPv6 CIDRs that intersect private, internal, or special-use ranges
  • Add advisory security notes for internal allowed_ips and hostless allowlists
  • Recompute security notes and the auto-approval prover verdict from the stored draft rule
  • Preserve hard rejection for destinations that the runtime always blocks
  • Add regression coverage and update user-facing and architecture documentation

Testing

  • mise run pre-commit passes
  • Unit tests added/updated
  • E2E tests added/updated (not applicable: no sandbox infrastructure change)

Additional validation: mise run lint and mise run test pass.

Checklist

  • Follows Conventional Commits
  • Commits are signed off (DCO)
  • Architecture docs updated (if applicable)

@alangou
alangou requested a review from mrunalp as a code owner July 22, 2026 13:43
@alangou alangou added the topic:security Security issues label Jul 22, 2026
@alangou
alangou requested review from a team, derekwaynecarr and maxamillion as code owners July 22, 2026 13:43
@alangou alangou added the topic:security Security issues label Jul 22, 2026
@alangou
alangou force-pushed the alangou/os-188-tava-2026-05-fsr-04-flag-private-allowed_ips-in-draft branch from 556fb1a to ba7e599 Compare July 22, 2026 14:23
@copy-pr-bot

copy-pr-bot Bot commented Jul 22, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions

Copy link
Copy Markdown

Signed-off-by: Adrien Langou <alangou@nvidia.com>
@alangou
alangou force-pushed the alangou/os-188-tava-2026-05-fsr-04-flag-private-allowed_ips-in-draft branch from ba7e599 to f21d61d Compare July 22, 2026 14:32
@alangou
alangou added this pull request to the merge queue Jul 22, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jul 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

topic:security Security issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants