fix(policy): keep internal allowed IP proposals pending#2416
Open
alangou wants to merge 1 commit into
Open
Conversation
alangou
requested review from
a team,
derekwaynecarr and
maxamillion
as code owners
July 22, 2026 13:43
alangou
force-pushed
the
alangou/os-188-tava-2026-05-fsr-04-flag-private-allowed_ips-in-draft
branch
from
July 22, 2026 14:23
556fb1a to
ba7e599
Compare
|
🌿 Preview your docs: https://nvidia-preview-pr-2416.docs.buildwithfern.com/openshell |
Signed-off-by: Adrien Langou <alangou@nvidia.com>
alangou
force-pushed
the
alangou/os-188-tava-2026-05-fsr-04-flag-private-allowed_ips-in-draft
branch
from
July 22, 2026 14:32
ba7e599 to
f21d61d
Compare
johntmyers
approved these changes
Jul 22, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Keep draft policy proposals pending when
allowed_ipstargets private or internal ranges. Re-evaluate auto-approval against the rule currently stored after edits and mechanistic deduplication so stale proposal analysis cannot bypass human review.Related Issue
closes OS-188
Changes
allowed_ipsand hostless allowlistsTesting
mise run pre-commitpassesAdditional validation:
mise run lintandmise run testpass.Checklist