Fix: add missing commit to release RileyLink#2
Open
marionbarker wants to merge 5 commits into
Open
Conversation
f6d56f9 made DetailedStatus return nil (not 0.0) when the fault time is 0x0000, a DASH reset-fault sentinel rather than a valid time. Update the two tests still asserting 0.0 (testPodInfoNoFaultAlerts, testPodInfoDuringPriming) to XCTAssertNil, matching the intended behavior.
OmniTests: faultEventTimeSinceActivation is nil for 0x0000 fault time
…-RileyLink Fix for loop-next-dev branch: Remove unneeded reference to release RLs when switching pump types
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
In preparing for this major change to BLE handling for OmnipodKit, there was one fix that was added at the loopandlearn upstream respository that did not make it into the loopkitdev fork where the work was originally done on this new method. When testing, I was cherry-picking to add it. But then forgot that it was not included.
Method
Created a matching branch at loopandlearn (upstream repository) OmnipodKit from the next-dev branch at LoopKit/OmnipodKit.
Merged the loopandlearn/OmnipodKit loop-next-dev branch into the next-dev branch at the loopandlearn respository.
The missing commit was cleanly added (as provided in this PR to LoopKit/OmnipodKit).