Fix for testStudyProtocolDesigner()#7871
Open
DariaBod wants to merge 6 commits into
Open
Conversation
Comment on lines
+99
to
+100
| new BaseManageVaccineDesignVisitPage.Visit(TestDataGenerator.randomName("NewVisit1", 3, 3, TRICKY_CHARACTERS, "\\").name(), 6.0, 7.0), | ||
| new BaseManageVaccineDesignVisitPage.Visit(TestDataGenerator.randomName("NewVisit2", 3, 3, TRICKY_CHARACTERS, "\\").name(), 8.0, 8.0) |
Member
There was a problem hiding this comment.
Any characters excluded from fuzzing should include an explanation in the code.
That being said, I ran this locally with a backslash intentionally added and it seems like there's a product defect. When we hit something like this in the tests, we should open an issue; that's the whole point of adding this fuzzing coverage.
Also, we should fuzz with TestDataGenerator.CHARSET_STRING. It contains a wider variety of characters that might cause problems.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
I added tricky characters to visit labels, but it broke this test. Reverted my changes and removed some hardcoded values.
Related Pull Requests
Changes