Sample type color field and color configuration#7866
Open
XingY wants to merge 18 commits into
Open
Conversation
cnathe
requested changes
Jul 23, 2026
Comment on lines
+115
to
+116
| if (getColorCount(container) >= DataColorManager.MAX_DATA_COLORS) | ||
| throw new QueryUpdateServiceException("Cannot add more than " + DataColorManager.MAX_DATA_COLORS + " colors."); |
Contributor
There was a problem hiding this comment.
this seems fine for now that this check includes all colors instead of just active ones, but I guess I was assuming this would not count the archived ones. either way this limit of 200 seems a bit arbitrary so we can adjust this accordingly if/when a client comes up agains the limit (which I doubt they will in practice)
cnathe
approved these changes
Jul 24, 2026
| if (toAdd.isEmpty() && toRemove.isEmpty()) | ||
| return false; | ||
|
|
||
| // Fix the sample type; vary the colors being disabled/re-enabled for it. |
Contributor
There was a problem hiding this comment.
this comment seems unnecessary
| if (toAdd.isEmpty() && toRemove.isEmpty()) | ||
| return Set.of(); | ||
|
|
||
| // Fix the color; vary the sample types it's disabled/re-enabled for. |
Contributor
There was a problem hiding this comment.
this comment seems unnecessary
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
This PR adds a new exp.material.ExpMaterialColor column so each sample can have its own color value. Previously sample color is defined at sample type level only.
Related Pull Requests
Changes
Sample Colorsexperimental flagcreateSampleTypeandupdateSampleTypeutil to persist sample color exclusions and their auditing