Skip to content

Improve release process to check for missing commits#248

Open
labkey-tchad wants to merge 16 commits into
developfrom
fb_prePublishTagCheck
Open

Improve release process to check for missing commits#248
labkey-tchad wants to merge 16 commits into
developfrom
fb_prePublishTagCheck

Conversation

@labkey-tchad

@labkey-tchad labkey-tchad commented Jul 23, 2026

Copy link
Copy Markdown
Member

Rationale

https://github.com/LabKey/internal-issues/issues/893
We've had a couple of releases this year (26.2.0 and 26.7.1) with incorrect commits due to hiccups in the release process. We have enough information when publishing to add some guard rails, checking that the expected release tag is being built.

Related Pull Requests

  • N/A

Changes

  • Update BuildUtils.getStandardVCSProperties to use Grgit instead of shelling out to git commands
  • Throw a GradleException from BuildUtils.getStandardVCSProperties if a non-SNAPSHOT labkeyVersion build's commit does not have a matching git tag
  • Add tagCheckExcludedProjects project property (-PtagCheckExcludedProjects=...) to exclude specific modules from this tag check

Comment thread src/main/groovy/org/labkey/gradle/util/BuildUtils.groovy Outdated
Comment thread src/main/groovy/org/labkey/gradle/util/BuildUtils.groovy Outdated
Comment thread src/main/groovy/org/labkey/gradle/util/BuildUtils.groovy Outdated
Comment thread src/main/groovy/org/labkey/gradle/util/BuildUtils.groovy Outdated
@labkey-adam

Copy link
Copy Markdown
Contributor

@labkey-tchad @labkey-susanh Not related and not critical (timing-wise), but since we're in here and we've switched to GA versions of Spring AI, feel free to remove the one-off Spring AI milestone version handling that Susan detests. See CheckForVersionConflicts.SPRING_AI_ARTIFACT_PREFIX.

@labkey-tchad labkey-tchad self-assigned this Jul 23, 2026
@labkey-tchad

Copy link
Copy Markdown
Member Author

@labkey-tchad @labkey-susanh Not related and not critical (timing-wise), but since we're in here and we've switched to GA versions of Spring AI, feel free to remove the one-off Spring AI milestone version handling that Susan detests. See CheckForVersionConflicts.SPRING_AI_ARTIFACT_PREFIX.

Sure. I've removed the spring-ai workaround

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants