fix(crop): crop variable field by absolute lat/lon range#126
Merged
Conversation
The variable-data crop filter (EAMExtract) trimmed by amounts measured from the global extent (range_to_trim) but applied them to the data's own bounds, while the base map (EAMTransformAndExtract) clipped at absolute lat/lon. The two frames only agree for global data, so a regional mesh (e.g. lat 55-85N) had its field mis-cropped while the map cropped correctly. Give EAMExtract absolute LongitudeRange/LatitudeRange and mask cell centers directly, in the same [-180,180] x [-90,90] frame as EAMTransformAndExtract. Drop range_to_trim; DataReader.crop now passes the raw [min, max] ranges. Both map and field now share one convention and crop consistently for any data extent.
Collaborator
Author
|
@jourdain please review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The variable-data crop filter (EAMExtract) trimmed by amounts measured from the global extent (range_to_trim) but applied them to the data's own bounds, while the base map (EAMTransformAndExtract) clipped at absolute lat/lon. The two frames only agree for global data, so a regional mesh (e.g. lat 55-85N) had its field mis-cropped while the map cropped correctly.
Give EAMExtract absolute LongitudeRange/LatitudeRange and mask cell centers directly, in the same [-180,180] x [-90,90] frame as EAMTransformAndExtract. Drop range_to_trim; DataReader.crop now passes the raw [min, max] ranges. Both map and field now share one convention and crop consistently for any data extent.