fix: support SQL-standard doubled quotes in string literals#65
Open
eaallen wants to merge 1 commit into
Open
Conversation
MySQL/SQL allow escaping a quote inside a string by doubling it (e.g. 'O''Hare'). The lexer only recognized backslash escapes, so these literals were split into multiple STRING tokens and failed to parse. Update the STRING lexer rules to accept '' and "" inside quoted strings, matching https://dev.mysql.com/doc/refman/5.7/en/string-literals.html Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
\'/\"), so MySQL/SQL-standard doubled quotes like'O''Hare'were tokenized as two strings and failed to parse.''/""inside quoted literals, matching MySQL 5.7 string literals.Test plan
npm test— all 37 tests pass locallynpm run build) and cut a release so npm consumers pick up the fixMade with Cursor