Update sklearnex gpu to use array_api_dispatch and dpnp#218
Draft
ethanglaser wants to merge 2 commits into
Draft
Update sklearnex gpu to use array_api_dispatch and dpnp#218ethanglaser wants to merge 2 commits into
ethanglaser wants to merge 2 commits into
Conversation
| conda env create -n rapids --solver=libmamba -f envs/conda-env-rapids.yml | ||
| ``` | ||
|
|
||
| GPU benchmarks using `sklearnex`'s `device: gpu` rely on scikit-learn's Array API support (`array_api_dispatch`), which requires `SCIPY_ARRAY_API=1` to be set in the environment before running: |
Contributor
There was a problem hiding this comment.
Sounds like it could be set inside the python process instead.
Contributor
Author
There was a problem hiding this comment.
It could but I don't think this is a great way to handle it
| and getattr(estimator_instance, "probability") == False | ||
| ): | ||
| y_pred_proba = convert_to_numpy(estimator_instance.predict_proba(x)) | ||
| # GPU/float32 predict_proba rows may drift outside roc_auc_score's |
Contributor
There was a problem hiding this comment.
This should be fixed in sklearnex instead. There is a code branch like this for random forests. If it happens for other classes, needs to be added for them too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Checklist:
Completeness and readability
Testing