Skip to content

add preprocessing benchmarking#216

Open
icfaust wants to merge 3 commits into
IntelPython:mainfrom
icfaust:dev/add_preprocessor_support
Open

add preprocessing benchmarking#216
icfaust wants to merge 3 commits into
IntelPython:mainfrom
icfaust:dev/add_preprocessor_support

Conversation

@icfaust

@icfaust icfaust commented Jul 10, 2026

Copy link
Copy Markdown
Collaborator

Description

Following uxlfoundation/scikit-learn-intelex#3020

Done with claude.


Checklist:

Completeness and readability

  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes or created a separate PR with updates and provided its number in the description, if necessary.
  • Git commit message contains an appropriate signed-off-by string (see CONTRIBUTING.md for details).
  • I have resolved any merge conflicts that might occur with the base branch.

Testing

  • I have run it locally and tested the changes extensively.
  • All CI jobs are green or I have provided justification why they aren't.
  • I have extended testing suite if new functionality was introduced in this PR.

"generation_kwargs": [
{ "n_samples": 100000, "n_features": 5000, "noise": 1.0 },
{ "n_samples": 1000000, "n_features": 500, "noise": 1.0 },
{ "n_samples": 10000000, "n_features": 50, "noise": 1.0 }

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps it could add cases with sparse data instead of something this large.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/uxlfoundation/scikit-learn-intelex/blob/main/sklearnex/preview/preprocessing/_data.py#L83 unfortunately not something we handle in the current moment (due to IncrementalBasicStatistics not handling sparse data).

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also the reason for such big data is to match order of magnitude to linear regression sizing https://github.com/IntelPython/scikit-learn_bench/blob/main/configs/regular/linear_model.json#L11

@david-cortes-intel

Copy link
Copy Markdown
Contributor

@icfaust Were you able to run this in a CI job?

@icfaust

icfaust commented Jul 24, 2026

Copy link
Copy Markdown
Collaborator Author

@icfaust Were you able to run this in a CI job?

Saw that CI was popping and held back. Will be testing it once CIs pass to see what comes out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants