fix: preserve LaunchDarkly boolean defaults#8055
Conversation
Resolve boolean flag defaults from the served fallthrough or off variation instead of the LaunchDarkly on toggle. Add focused coverage for both inverted cases.
|
@Sanjays2402 is attempting to deploy a commit to the Flagsmith Team on Vercel. A member of the Team first needs to authorize it. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughBoolean LaunchDarkly feature-state imports now derive Estimated code review effort: 2 (Simple) | ~10 minutes Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature.Changes
Closes #8047
Boolean LaunchDarkly imports now derive the environment default from the served fallthrough or off variation instead of the separate on/off toggle. Unsupported rollout or non-boolean values retain the existing toggle fallback.
How did you test this code?
Added focused tests for on-but-serving-false and off-but-serving-true configurations. The focused pytest cases, Ruff, formatting, Mypy, and both outgoing diff gates pass.