DRAFT. Expand test for geoscience libraries - #59
Conversation
sarahw-earthscope
left a comment
There was a problem hiding this comment.
This looks good to me!
We need to ensure the developer checklist includes instructions to update these test files with any new packages they add.
| import dascore | ||
|
|
||
| assert hasattr(dascore, "__version__") | ||
| import dascore as dc |
There was a problem hiding this comment.
Not a comment on the test package... but we need to consider why we are including dascore in the image build at all. We don't currently provide das data through our archive, and I'm not sure we want to encourage researchers to upload das data (big files) to geolab for the sole purpose of processing it.
There was a problem hiding this comment.
I would remove obstore, we don't want to encourage downloading and storage of data
There was a problem hiding this comment.
I would remove obsplus, we don't want to encourage downloading and storage of data
Deepens the tests for four geophysics libraries from import/version-only checks to a real operation that exercises the package's core functionality:
gmt-gshhg/gmt-dcw, which nothing tested before)All tests use bundled or synthetic data that require no network, no credentials, no external files.
Ran
pytest test_packages.py -vand re-ran thetest_notebook.ipynbnotebook cells in GeoLab and all tests passed.