SChunk.meta.get: Fix infinite recursion#681
Open
Zentrik wants to merge 2 commits into
Open
Conversation
Author
|
I guess I should add a test |
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes the SChunk.meta.get() implementation in src/blosc2/schunk.py to avoid infinite recursion (Issue #679), restoring correct Mapping.get-style behavior for fixed-length metadata access on SChunk.
Changes:
- Replace the recursive
Meta.get()implementation with a non-recursive lookup that returnsdefaultfor missing keys.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+154
to
+157
| def get(self, key: str, default: Any = None) -> Any: | ||
| """Return the value for `key` if `key` is in the dictionary, else return `default`. | ||
| If `default` is not given, it defaults to ``None``.""" | ||
| return self.get(key, default) | ||
| return self[key] if key in self else default |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #679