feat: add surface-aware shortcuts#418
Merged
Merged
Conversation
BorisTyshkevich
marked this pull request as ready for review
July 24, 2026 11:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a shared, surface-aware shortcut catalog for SQL Browser and Dashboard.
Gnavigation commands while preserving Workbench commands on SQL Browser only.role="textbox"suppression.Why
The shared shortcut-help control previously documented Workbench commands on Dashboard and
?could not open contextual help there.Review also identified modal surfaces that did not participate in keyboard ownership, stale body-mounted help surviving surface/authentication transitions, and a separately hardcoded chord routing table. Those gaps could run commands behind dialogs, cancel a query with the same Escape used to close a result drawer, and let help drift from runtime behavior.
Validation
npm test— 5,083 passing tests; strict TypeScript, architecture checks, and per-file coverage gates pass.npm run build— single-filedist/sql.htmlbuild succeeds.Closes #417.