TPC: add UseGeant4Edep ionisation-fluctuation flag for Kr-83m calibration simulations#15615
Open
Ankyyadav wants to merge 1 commit into
Open
TPC: add UseGeant4Edep ionisation-fluctuation flag for Kr-83m calibration simulations#15615Ankyyadav wants to merge 1 commit into
Ankyyadav wants to merge 1 commit into
Conversation
Ankyyadav
marked this pull request as draft
July 21, 2026 09:25
Ankyyadav
added a commit
to Ankyyadav/AliceO2
that referenced
this pull request
Jul 21, 2026
Please consider the following formatting changes to AliceO2Group#15615
Ankyyadav
force-pushed
the
feature/tpc-kr-calibration-generator
branch
from
July 23, 2026 13:54
833f9a1 to
dfc712d
Compare
Ankyyadav
force-pushed
the
feature/tpc-kr-calibration-generator
branch
from
July 23, 2026 14:01
dfc712d to
cc9dea4
Compare
Ankyyadav
marked this pull request as ready for review
July 23, 2026 14:04
wiechula
requested changes
Jul 24, 2026
Comment on lines
+35
to
+41
| namespace KrGenConfig | ||
| { | ||
| inline double rInner = 83.5; | ||
| inline double rOuter = 246.5; // TPC outermost pad row outer edge ~247 cm; stay inside | ||
| inline double halfZ = 249.7; | ||
| inline int nPerEvent = 1000; // override at runtime via KR_N_PER_EVENT env var | ||
| } // namespace KrGenConfig |
Collaborator
There was a problem hiding this comment.
Is this namespace needed? I guess the variables could also go to the class.
If you would like to keep it follow the naming convention for the namespaces: lower case with underscore
namespace kr_gen_config
Part of the variable can then be const or constexpr.
Author
There was a problem hiding this comment.
Thanks for the comments. I have made the changes
Comment on lines
+43
to
+46
| struct KrProduct { | ||
| int pdg; | ||
| double eKin; | ||
| }; |
Collaborator
There was a problem hiding this comment.
Seems to be only used in KrDecayTable, so it could also go there.
Comment on lines
+168
to
+171
| std::cout << "[KrDecayTable] Loaded from " << path << "\n" | ||
| << " T1: E=" << fE1 << " keV ICC=" << ICC_T1 | ||
| << " K_frac=" << Kfrac_T1 << "\n" | ||
| << " T2: E=" << fE2 << " keV ICC=" << ICC_T2 << "\n"; |
Collaborator
There was a problem hiding this comment.
Use LOG(info) and remove last \n. Also in other places. Or the appropriate log level.
| o2::tpc::KrGenConfig::nPerEvent = n; | ||
| } | ||
| } | ||
| std::cout << "[GeneratorKrDecay] Init:" |
| << " K_frac=" << Kfrac_T1 << "\n" | ||
| << " T2: E=" << fE2 << " keV ICC=" << ICC_T2 << "\n"; | ||
| } else { | ||
| std::cout << "[KrDecayTable] WARNING: could not parse " << path |
| << " — using hardcoded fallback values\n"; | ||
| } | ||
| } else { | ||
| std::cout << "[KrDecayTable] WARNING: G4LEVELGAMMADATA not set" |
| Bool_t importParticles() override; | ||
|
|
||
| private: | ||
| o2::tpc::KrDecayTable* mTable; |
…on support - TPCDetParam.UseGeant4Edep: use Geant4's own energy deposit for ionisation instead of Bethe-Bloch/NA49, with a configurable SpecialCutsGeV threshold - Adds the Kr-83m decay generator (GeneratorKrDecay) as a compiled Generator subclass in Detectors/TPC/simulation, with a thin krGenerator.C macro for use as an o2-sim external generator - Adds plotCluster.C for viewing the resulting calibration spectrum
Ankyyadav
force-pushed
the
feature/tpc-kr-calibration-generator
branch
from
July 24, 2026 09:01
cc9dea4 to
d6a0c54
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TPCDetParam.UseGeant4Edep, an opt-in flag (default off) that uses Geant4's energy deposit directly for ionisation inDetector::ProcessHits, with Fano-limited charge fluctuation via a Gamma-distributed smear (mean/variance tuned for GEANT4). Used for 83mKr TPC calibration simulations.SetSpecialPhysicsCuts()callsmatmgr.SpecialCut()for the TPC drift-gas media before the base class readssimcuts.dat(which sets a 10 keV default for these media). This is now exposed asTPCDetParam.SpecialCutsGeV(default 1e-6 GeV = 1 keV), so the actual effective cutcan be set via configKeyValues.