replace: Should property accessors be replaced or not?

[GrygrFlzr]

• Rollup Plugin Name: @rollup/plugin-replace
• Rollup Plugin Version: 6.0.3
• Rollup Version: 4.62.0
• Operating System (or Browser): macOS 15.7.7 (local), unknown (stackblitz)
• Node Version: v22.22.3
• Link to reproduction (⚠️ read below): https://stackblitz.com/edit/rollup-repro-amxnsxzx?file=dist%2Fmain.js&view=editor

Expected Behavior

Given this test added in #1938 merged into 6.0.3:

plugins/packages/replace/test/fixtures/form/dollar-sign-boundary/input.js

Lines 17 to 20 in 639f456

	// Should be replaced - typeof window followed by dot
	if (typeof window.document !== 'undefined') {
	console.log('has document');
	}

plugins/packages/replace/test/fixtures/form/dollar-sign-boundary/_config.js

Lines 2 to 8 in 639f456

	description: 'should not replace when followed by valid identifier characters',
	options: {
	values: {
	'typeof window': '"undefined"'
	},
	preventAssignment: true
	}

Comment strongly suggests it should produce the following replacement:

// Should be replaced - typeof window followed by dot
if ("undefined".document !== 'undefined') {
  console.log('has document');
}

Actual Behavior

The snapshot stored by vitest does not actually replace this:

plugins/packages/replace/test/snapshots/form.js.md

Lines 43 to 46 in 639f456

	// Should be replaced - "undefined" followed by dot␊
	if (typeof window.document !== 'undefined') {␊
	console.log('has document');␊
	}`

And, there is an older fixture + snapshot which directly conflicts with this interpretation, under replace-nothing:

plugins/packages/replace/test/fixtures/form/replace-nothing/input.js

Lines 1 to 2 in 639f456

	console.log('as-it'); // eslint-disable-line
	console.log(typeof window.document); // eslint-disable-line

plugins/packages/replace/test/fixtures/form/replace-nothing/_config.js

Lines 2 to 5 in 639f456

	description: 'replaces nothing',
	options: {
	'typeof window': `"object"`
	}

Vitest Snapshot:

plugins/packages/replace/test/snapshots/form.js.md

Lines 76 to 81 in 639f456

	## replace-nothing: replaces nothing
	> Snapshot 1
	`console.log('as-it'); // eslint-disable-line␊
	console.log(typeof window.document); // eslint-disable-line`

Additional Information

The older PR which introduced the replace-nothing test was #903 which had the following comment:

Personally, I believe it's dangerous to replace VERSION in the case you highlighted by default:

if (VERSION.startsWith('foo')) {
  // things
}

In the case above with the previous default to match VERSION when used with a . or nested access, you would need to know all of your dependencies' code, not to mess up when replacing.

Originally posted by @o-alexandrov in #903 (comment)

What is the current intended behavior? I don't think these two tests can co-exist unless they're testing differently configured delimiters.

[shellscape]

Thanks for the issue. I think you would be better served by replying to the PR and tagging the PR author.