You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I created a stack of three PRs (master <- 1 <- 2 <- 3) that were all created by myself. All commits in the PRs were also created by myself.
A co-worker approved PRs 1 and 2 and then merged PR 2 using the “Squash and merge Stack” functionality. As expected this resulted in two commits on master, carrying the expected commit message and committer. The author field of the resulting commits however was internally inconsistent:
The real name matches my name (PR author), but the email address matches that of my coworker (PR merger):
commit 01973150e00f7e4e532205a09158597dadc656ee
Author: Tim Düsterhus <2*redacted*+e*redacted*@users.noreply.github.com>
AuthorDate: 53 minutes ago
Commit: GitHub <noreply@github.com>
CommitDate: 53 minutes ago
For regular non-stacked PRs, the author information correctly shows my real name + the email address I used for the PR’s commits (my corporate email address, rather than my GitHub default email address).
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
Uh oh!
There was an error while loading. Please reload this page.
-
I created a stack of three PRs (master <- 1 <- 2 <- 3) that were all created by myself. All commits in the PRs were also created by myself.
A co-worker approved PRs 1 and 2 and then merged PR 2 using the “Squash and merge Stack” functionality. As expected this resulted in two commits on master, carrying the expected commit message and committer. The author field of the resulting commits however was internally inconsistent:
The real name matches my name (PR author), but the email address matches that of my coworker (PR merger):
For regular non-stacked PRs, the author information correctly shows my real name + the email address I used for the PR’s commits (my corporate email address, rather than my GitHub default email address).
Beta Was this translation helpful? Give feedback.
All reactions